Fix failing errata ui tests by aidenfine · Pull Request #20840 · SatelliteQE/robottelo

aidenfine · 2026-02-23T16:01:51Z

Problem Statement

Some Errata UI tests failing due to content hosts page removal

Solution

Remove/fix parts of test that use content hosts page

Related Issues

https://issues.redhat.com/browse/SAT-42273

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py -k "positive_check_errata or positive_content_host_previous_env or positive_errata_search_type or positive_filtered_errata_status_installable_param"

PRT usage reference link: https://github.com/SatelliteQE/robottelo/wiki/Robottelo-Pull-Request-Testing-(PRT)-Process#usage-examples

Summary by Sourcery

Adjust errata UI tests to avoid removed content hosts page and ensure errata applicability is reflected after package installation tasks complete.

Bug Fixes:

Remove reliance on the deprecated content hosts page in errata UI tests that caused failures.
Ensure errata-related tests wait for and verify bulk applicability generation tasks after yum installs to avoid timing-related failures.

Enhancements:

Tag affected errata UI tests with the no_containers marker and standardize timestamp formatting using the shared time format constant.

sourcery-ai · 2026-02-23T16:01:57Z

Reviewer's Guide

This PR updates errata UI tests to remove dependencies on the deprecated content hosts page and to make errata applicability checks more robust and deterministic, mainly by removing an obsolete assertion block, adding container-skipping markers, normalizing timestamp handling, and explicitly waiting for applicability tasks after yum installations.

File-Level Changes

Change	Details	Files
Remove obsolete verification using the deprecated content hosts page in the previous environment test.	Deleted the session-based navigation and search_errata call against the content hosts page for a VM in a previous lifecycle environment. Removed the assertion that verified the expected errata ID via the content host errata search in the previous environment.	`tests/foreman/ui/test_errata.py`
Strengthen errata search and status tests by synchronizing on applicability tasks and using consistent timestamp formatting.	In the host content errata search-by-type test, added dependency on module_target_sat, captured hostname and a formatted install timestamp, and waited for Bulk generate applicability tasks after yum install, asserting at least one task is found. In the errata counts-by-type test, changed the install_timestamp from a datetime object to a formatted string using TIMESTAMP_FMT to align with task search expectations. In the filtered errata status installable parameter test, added a formatted install timestamp, waited for Bulk generate applicability tasks after yum install on the client, and asserted that at least one such task is found.	`tests/foreman/ui/test_errata.py`
Add markers to skip certain errata tests in containerized environments.	Applied the @pytest.mark.no_containers marker to the errata search-by-type host test. Applied the @pytest.mark.no_containers marker to the errata counts-by-type host details test and the upgrade errata status installable test.	`tests/foreman/ui/test_errata.py`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

Hey - I've left some high level feedback:

The new applicability wait logic (computing install_timestamp, running yum install, and then polling module_target_sat.wait_for_tasks) is duplicated across multiple tests; consider extracting this into a small helper to keep the tests DRY and easier to maintain.
Now that install_timestamp is formatted via strftime(TIMESTAMP_FMT) in some tests but not others, it might be worth standardizing the timestamp handling (possibly by a shared helper) to avoid subtle differences in how started_at filters are constructed.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The new applicability wait logic (computing `install_timestamp`, running `yum install`, and then polling `module_target_sat.wait_for_tasks`) is duplicated across multiple tests; consider extracting this into a small helper to keep the tests DRY and easier to maintain.
- Now that `install_timestamp` is formatted via `strftime(TIMESTAMP_FMT)` in some tests but not others, it might be worth standardizing the timestamp handling (possibly by a shared helper) to avoid subtle differences in how `started_at` filters are constructed.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

aidenfine · 2026-02-23T16:02:58Z

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py

Satellite-QE · 2026-02-23T18:52:01Z

PRT Result

Build Number: 14415
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_errata.py --external-logging
Test Result : =========== 7 failed, 25 passed, 865 warnings in 9382.00s (2:36:22) ============

aidenfine · 2026-02-23T19:15:43Z

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py -k "positive_check_errata or positive_content_host_previous_env or positive_errata_search_type or positive_filtered_errata_status_installable_param"

vsedmik

One Q

vsedmik · 2026-02-24T10:21:29Z

        assert host_tab_erratum[0]['Errata'] == CUSTOM_REPO_ERRATA_ID


+@pytest.mark.no_containers


Wonder if we can keep the container hosts (they are deployed much faster and should be sufficient for these cases) and get these tests passing.

Does the consequential wait_for_tasks fail, or what it the reason behind this change?

I was unable to get wait_for_tasks to pass without that pytest mark. Do you know the reason for this?

I think it could be related to the package profile upload again. Will need to check..

@vsedmik what if we use container_host as it is and just update search query to include orgnization id in it?
ex-

search_query=( f'Bulk generate applicability for host {hostname}' f' and started_at >= "{install_timestamp}"' f' and organzation_id = {module_sca_manifest_org.id}' )

IMHO not necessary @vijaysawant. PRT passed as is.

aidenfine · 2026-02-24T14:08:54Z

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py -k "positive_check_errata or positive_content_host_previous_env or positive_errata_search_type or positive_filtered_errata_status_installable_param"

aidenfine · 2026-02-24T20:25:27Z

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py -k "positive_check_errata or positive_content_host_previous_env or positive_errata_search_type or positive_filtered_errata_status_installable_param"

vijaysawant

@aidenfine can you check with the suggested changes?
use content_host and update search query to include host id.

vijaysawant · 2026-02-25T10:37:40Z

        assert host_tab_erratum[0]['Errata'] == CUSTOM_REPO_ERRATA_ID


+@pytest.mark.no_containers


@vsedmik what if we use container_host as it is and just update search query to include orgnization id in it?
ex-

search_query=( f'Bulk generate applicability for host {hostname}' f' and started_at >= "{install_timestamp}"' f' and organzation_id = {module_sca_manifest_org.id}' )

aidenfine · 2026-02-25T14:44:00Z

trigger: test-robottelo
pytest: tests/foreman/ui/test_errata.py -k "positive_check_errata or positive_content_host_previous_env or positive_errata_search_type or positive_filtered_errata_status_installable_param"

vsedmik

Looks good to me

vijaysawant

Looks good. Ack.

* fix failing errata tests * add subscription-manager repo command to fix failing test * remove no containers mark * remove no_containers from test_positive_errata_search_type (cherry picked from commit 6e909f9)

fix failing errata tests

63c91da

aidenfine requested a review from a team as a code owner February 23, 2026 16:01

github-actions Bot assigned aidenfine Feb 23, 2026

sourcery-ai Bot reviewed Feb 23, 2026

View reviewed changes

aidenfine added the No-CherryPick PR doesnt need CherryPick to previous branches label Feb 23, 2026

Merge branch 'master' into SAT-39214-fix-ui-errata-tests

42211ea

Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Feb 23, 2026

vsedmik reviewed Feb 24, 2026

View reviewed changes

add subscription-manager repo command to fix failing test

8fe914c

remove no containers mark

e28d7b2

vijaysawant requested changes Feb 25, 2026

View reviewed changes

remove no_containers from test_positive_errata_search_type

42f08c6

vsedmik approved these changes Feb 25, 2026

View reviewed changes

vijaysawant approved these changes Feb 26, 2026

View reviewed changes

aidenfine merged commit 6e909f9 into SatelliteQE:master Feb 26, 2026
16 checks passed

Satellite-QE mentioned this pull request Feb 26, 2026

[6.19.z] Fix failing errata ui tests #20897

Closed

		assert host_tab_erratum[0]['Errata'] == CUSTOM_REPO_ERRATA_ID


		@pytest.mark.no_containers

Uh oh!

Conversation

aidenfine commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem Statement

Solution

Related Issues

PRT test Cases example

Summary by Sourcery

Uh oh!

sourcery-ai Bot commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

aidenfine commented Feb 23, 2026

Uh oh!

Satellite-QE commented Feb 23, 2026

Uh oh!

aidenfine commented Feb 23, 2026

Uh oh!

vsedmik left a comment

Choose a reason for hiding this comment

Uh oh!

vsedmik Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

aidenfine Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

vsedmik Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

vijaysawant Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

vsedmik Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

aidenfine commented Feb 24, 2026

Uh oh!

aidenfine commented Feb 24, 2026

Uh oh!

vijaysawant left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vijaysawant Feb 25, 2026

Choose a reason for hiding this comment

Uh oh!

aidenfine commented Feb 25, 2026

Uh oh!

vsedmik left a comment

Choose a reason for hiding this comment

Uh oh!

vijaysawant left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

aidenfine commented Feb 23, 2026 •

edited

Loading

sourcery-ai Bot commented Feb 23, 2026 •

edited

Loading